Opened 11 years ago
Closed 10 years ago
#11 closed task (fixed)
Introduce the ability to float parameters of lineshapes, e.g. masses and widths
Reported by: | Thomas Latham | Owned by: | Thomas Latham |
---|---|---|---|
Priority: | major | Milestone: | v3r0 |
Version: | Keywords: | ||
Cc: |
Description
Change History (27)
comment:1 Changed 11 years ago by
Type: | defect → task |
---|
comment:2 Changed 11 years ago by
Milestone: | → Release v3r0 |
---|---|
Status: | new → assigned |
comment:3 Changed 11 years ago by
comment:4 Changed 11 years ago by
comment:5 Changed 11 years ago by
comment:6 Changed 11 years ago by
(In [116]) Address issue of setting values of resonance parameters for all models. Decided to do away with need to have LauIsobarDynamics know everything. LauIsobarDynamics::addResonance now returns a pointer to LauAbsResonance. Parameters can be changed through LauAbsResonance::setResonanceParameter. LauIsobarDynamics still knows about Blatt-Weisskopf factors - better to only need to set this once. Update GenFit3pi example to demonstrate mechanism. oktotest #34 This should also help with implementing the floating resonance parameters. addresses #11
comment:7 Changed 11 years ago by
comment:8 Changed 11 years ago by
comment:9 Changed 11 years ago by
comment:10 Changed 11 years ago by
(In [135]) Large update - now starting to allow other resonance parameters to float. The alpha parameter of the LauBelleNR and LauBelleSymNR lineshapes are working in this version. Will propagate mechanism to other shapes in next update. The mechanism for getting the floating parameters to the fit model is moved from LauResonanceMaker to the the resonances themselves via LauIsobarDynamics. This lays some of the groundwork for tracking which integrals need to be updated. addresses #11
comment:11 Changed 11 years ago by
(In [136]) Allow the LASS parameters to float and introduce the efficiency saving in the amplitude calculation. Remove R, B, phiR, phiB parameters from complete LASS shape - not needed with the separate shapes available. Add missing method from LauBelleSymNR. Minor fix to doxygen for LauBelleNR. addresses #11 addresses #21
comment:12 Changed 11 years ago by
comment:13 Changed 11 years ago by
comment:14 Changed 11 years ago by
comment:15 Changed 11 years ago by
comment:16 Changed 11 years ago by
comment:17 Changed 10 years ago by
comment:18 Changed 10 years ago by
comment:19 Changed 10 years ago by
comment:20 Changed 10 years ago by
comment:21 Changed 10 years ago by
comment:22 Changed 10 years ago by
comment:23 Changed 10 years ago by
Issues still outstanding on this ticket:
- Blatt--Weisskopf barrier factors need some work to allow them to float
- Can have large memory usage, O(GBs), if the integration grid is very finely binned (I fear that there is no way around this but at the very least we should try and print warnings if the usage will go over some amount and perhaps try and make the binning more tunable)
Should probably do a full profile and apply any tweaks to improve timing before releasing this.
comment:24 Changed 10 years ago by
comment:25 Changed 10 years ago by
(In [191]) Add new method to LauResonanceMaker to set whether the radius of a given Blatt-Weisskopf category should be fixed of floated. Modify the methods of LauResonanceMaker to set the radius value and whether it should be floated so that they work before and after the resonances have been created. addresses #11
comment:26 Changed 10 years ago by
comment:27 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Profile shows that things are pretty good. One possibility to save a lot of time is to cache all the kinematics information for each grid point and for each event since approx 40-50% of the CPU time is in recalculating all the helicity angles, daughter momenta etc. from the two DP co-ordinates. We'd need to check the memory consumption very carefully but it could be a big saving. Will create a new ticket for this issue and close this one so that v3r0 can be released.
(In [87]) Commit in work done mainly by Juan (with some help from me) to get something working in terms of floating masses and widths. Works nicely! Currently only in certain cases (RelBW, resonance wider than threshold for special integration treatment). Needs to be generalised (both in terms of lineshapes and also allow all resonance parameters to float not just masses and widths) and made much more efficient. addresses #11