Opened 8 years ago
Closed 8 years ago
#73 closed defect (fixed)
LauEffModel does not deal correctly with multiple addEffHisto and addEffSpline with different squareDP arguments
| Reported by: | Thomas Latham | Owned by: | Thomas Latham |
|---|---|---|---|
| Priority: | major | Milestone: | v3r2 |
| Version: | v2r2 | Keywords: | |
| Cc: |
Description
In LauEffModel::addEff* methods, the value of squareDP_ is overwritten with the value passed as an argument to the function. So if the function is called multiple times (as is the intention) with different values of the squareDP argument, LauEffModel will treat all components of the efficiency as if they have the value of the last one provided, i.e. all as square DP or all as classic DP. Best solution is for LauEffModel to not store square/classic information itself but to ask each component for its preference and then provide the appropriate coordinates.
Note: See
TracTickets for help on using
tickets.
(In [393]) Permit different efficiency histograms to be defined in classic/square DP and force enable calculation of square DP coords (here and for background PDFs) if required, fixes #73