Problem with addIncoherentResonance in v3.0

[guest]

Dear developers,

I have been through a bug when trying to add a component incoherently. Although it happened with my own ppbar modeling, to ease your understanding, I have repeated the crash with a minimal modification of your example GenFit3pi, adding the non-resonant component incoherently instead of coherently (see attachment).

When I run ./GenFit3pi gen 10, this is the message I get:

INFO in LauDaughters::setParentType : Setting parent to be B+ == 521 INFO in LauDaughters::setDaugType : Setting daughter 1 to be pi+ == 211 INFO in LauDaughters::setDaugType : Setting daughter 2 to be pi+ == 211 INFO in LauDaughters::setDaugType : Setting daughter 3 to be pi- == -211 INFO in LauDaughters::testDPSymmetry : We have a symmetrical DP. INFO in LauKinematics::LauKinematics : squareDP = kFALSE INFO in LauResonanceMaker::createResonanceVector : Setting up possible resonance states... INFO in LauResonanceMaker::getResonance : Creating resonance: rho0(770)

: Using Gounaris-Sakurai lineshape.

INFO in LauBlattWeisskopfFactor constructor : creating radius parameter for category "Light", with initial value 4 INFO in LauBlattWeisskopfFactor constructor : creating radius parameter for category "Parent", with initial value 5 INFO in LauIsobarDynamics::addResonance : Successfully added resonance. Total number of resonances so far = 1 INFO in LauResonanceMaker::getResonance : Creating resonance: rho0(1450)

: Using relativistic Breit-Wigner lineshape.

INFO in LauIsobarDynamics::addResonance : Successfully added resonance. Total number of resonances so far = 2 INFO in LauResonanceMaker::getResonance : Creating resonance: f_0(980)

: Using Flatte lineshape.

INFO in LauIsobarDynamics::addResonance : Successfully added resonance. Total number of resonances so far = 3 INFO in LauFlatteRes::setResonanceParameter : Setting g1 parameter to 0.2 INFO in LauFlatteRes::setResonanceParameter : Setting g2 parameter to 1 INFO in LauResonanceMaker::getResonance : Creating resonance: f_2(1270)

: Using relativistic Breit-Wigner lineshape.

INFO in LauIsobarDynamics::addResonance : Successfully added resonance. Total number of resonances so far = 4 INFO in LauResonanceMaker::getResonance : Creating resonance: NonReson

: Using uniform NR lineshape.

INFO in LauIsobarDynamics::addIncohResonance : Successfully added incoherent resonance. Total number of incoherent resonances so far = 1 INFO in LauSimpleFitModel::setAmpCoeffSet : Added coefficients for component "rho0(770)" to the fit model. INFO in LauMagPhaseCoeffSet::printParValues : Component "rho0(770)" has magnitude = 1 and phase = 0. INFO in LauSimpleFitModel::setAmpCoeffSet : Added coefficients for component "rho0(1450)" to the fit model. INFO in LauMagPhaseCoeffSet::printParValues : Component "rho0(1450)" has magnitude = 0.37 and phase = 1.99. INFO in LauSimpleFitModel::setAmpCoeffSet : Added coefficients for component "f_0(980)" to the fit model. INFO in LauMagPhaseCoeffSet::printParValues : Component "f_0(980)" has magnitude = 0.27 and phase = -1.59. INFO in LauSimpleFitModel::setAmpCoeffSet : Added coefficients for component "f_2(1270)" to the fit model. INFO in LauMagPhaseCoeffSet::printParValues : Component "f_2(1270)" has magnitude = 0.53 and phase = 1.39. INFO in LauSimpleFitModel::setAmpCoeffSet : Added coefficients for component "NonReson" to the fit model. INFO in LauMagPhaseCoeffSet::printParValues : Component "NonReson" has magnitude = 0.54 and phase = -0.84. INFO in LauSimpleFitModel::initialiseDPModels : Initialising DP models INFO in LauIsobarDynamics::initSummary : We are going to do a DP with B+ going to pi+ pi+ pi-

: For the following resonance combinations: : In tracks 2 and 3: : rho0(770) to pi+, pi- : rho0(1450) to pi+, pi- : f_0(980) to pi+, pi- : f_2(1270) to pi+, pi-

: In tracks 1 and 3:

: In tracks 1 and 2:

INFO in LauIsobarDynamics::initialise : Starting special run to generate the integrals for normalising the PDF... INFO in LauIsobarDynamics::calcDPNormalisationScheme : No narrow resonances found, integrating over whole Dalitz plot... INFO in LauDPPartialIntegralInfo constructor : nm13Points = 972, nm23Points = 972

: m13BinWidth = 0.005, m23BinWidth = 0.005 : Integrating over m13 = 0.27914 to 5.13969, m23 = 0.27914 to 5.13969 : totm13Weight = 2, totm23Weight = 2

* Break * segmentation violation

=========================================================== There was a crash. This is the entire stack trace of all threads: =========================================================== #0 0x00007f01012326dc in libc_waitpid (pid=13147, stat_loc=stat_loc entry=0x7fff0bf19780, options=options entry=0) at ../sysdeps/unix/sysv/linux/waitpid.c:31 #1 0x00007f01011b72e2 in do_system (line=<optimized out>) at ../sysdeps/posix/system.c:148 #2 0x00007f010323c3a3 in TUnixSystem::StackTrace() () from /usr/lib/x86_64-linux-gnu/libCore.so.5.34 #3 0x00007f010323e07c in TUnixSystem::DispatchSignals(ESignals) () from /usr/lib/x86_64-linux-gnu/libCore.so.5.34 #4 <signal handler called> #5 0x0000000000000000 in ?? () #6 0x00007f0103a572c4 in LauIsobarDynamics::incohResAmp (this=this entry=0x1bc19d0, index=index entry=0) at src/LauIsobarDynamics.cc:1733 #7 0x00007f0103a58acb in LauIsobarDynamics::calculateAmplitudes (this=this entry=0x1bc19d0, intInfo=intInfo entry=0x1bc82e0, m13Point=m13Point entry=0, m23Point=<optimized out>) at src/LauIsobarDynamics.cc:1534 #8 0x00007f0103a58c7c in LauIsobarDynamics::calcDPPartialIntegral (this=this entry=0x1bc19d0, intInfo=0x1bc82e0) at src/LauIsobarDynamics.cc:1497 #9 0x00007f0103a5ecb0 in LauIsobarDynamics::calcDPNormalisation (this=this entry=0x1bc19d0) at src/LauIsobarDynamics.cc:958 #10 0x00007f0103a65504 in LauIsobarDynamics::initialise (this=0x1bc19d0, coeffs=...) at src/LauIsobarDynamics.cc:359 #11 0x00007f0103a9a54c in LauSimpleFitModel::initialiseDPModels (this=0x1bc34a0) at src/LauSimpleFitModel.cc:382 #12 0x00007f0103aa5529 in LauSimpleFitModel::initialise (this=0x1bc34a0) at src/LauSimpleFitModel.cc:275 #13 0x00007f0103a0916b in LauAbsFitModel::run (this=this entry=0x1bc34a0, applicationCode=..., dataFileName=..., dataTreeName=..., histFileName=..., tableFileName=...) at src/LauAbsFitModel.cc:129 #14 0x000000000040269c in main (argc=<optimized out>, argv=<optimized out>) at GenFit3pi.cc:213 ===========================================================

The lines below might hint at the cause of the crash. If they do not help you then please submit a bug report at ​http://root.cern.ch/bugs. Please post the ENTIRE stack trace from above as an attachment in addition to anything else that might help us fixing this issue. =========================================================== #5 0x0000000000000000 in ?? () #6 0x00007f0103a572c4 in LauIsobarDynamics::incohResAmp (this=this entry=0x1bc19d0, index=index entry=0) at src/LauIsobarDynamics.cc:1733 #7 0x00007f0103a58acb in LauIsobarDynamics::calculateAmplitudes (this=this entry=0x1bc19d0, intInfo=intInfo entry=0x1bc82e0, m13Point=m13Point entry=0, m23Point=<optimized out>) at src/LauIsobarDynamics.cc:1534 #8 0x00007f0103a58c7c in LauIsobarDynamics::calcDPPartialIntegral (this=this entry=0x1bc19d0, intInfo=0x1bc82e0) at src/LauIsobarDynamics.cc:1497 #9 0x00007f0103a5ecb0 in LauIsobarDynamics::calcDPNormalisation (this=this entry=0x1bc19d0) at src/LauIsobarDynamics.cc:958 #10 0x00007f0103a65504 in LauIsobarDynamics::initialise (this=0x1bc19d0, coeffs=...) at src/LauIsobarDynamics.cc:359 #11 0x00007f0103a9a54c in LauSimpleFitModel::initialiseDPModels (this=0x1bc34a0) at src/LauSimpleFitModel.cc:382 #12 0x00007f0103aa5529 in LauSimpleFitModel::initialise (this=0x1bc34a0) at src/LauSimpleFitModel.cc:275 #13 0x00007f0103a0916b in LauAbsFitModel::run (this=this entry=0x1bc34a0, applicationCode=..., dataFileName=..., dataTreeName=..., histFileName=..., tableFileName=...) at src/LauAbsFitModel.cc:129 #14 0x000000000040269c in main (argc=<optimized out>, argv=<optimized out>) at GenFit3pi.cc:213 ===========================================================

Cheers, Adlene

[Daniel Craik]

Incoherent resonances have their own set of line shapes- currently only LauAbsResonance::GaussIncoh. This should throw a helpful error message.

[Daniel Craik]

(In [291]) Add checks to LauIsobarDynamics::addResonance and LauIsobarDynamics::addIncohResonance to stop the wrong type of LauResonanceModel being used. closes #53